Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added all available system variable #5232

Closed
wants to merge 2 commits into from
Closed

added all available system variable #5232

wants to merge 2 commits into from

Conversation

Abdullium
Copy link

@Abdullium Abdullium commented Aug 8, 2022

Just below the "Custom Virtual Environment Location" I have added all the system environment variable

Thank you for contributing to Pipenv!

The issue

What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.

Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.

If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.

https://github.com/pypa/pipenv/blob/master/peeps/PEEP-000.md

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Just below the "Custom Virtual Environment Location" I have added all the system environment variable
@oz123
Copy link
Contributor

oz123 commented Aug 8, 2022

This approach requires manual labor to document the variables if they are removed or added.
Please see my branch here:
https://github.com/pypa/pipenv/tree/document-environment-variables

You can steal this code, and add the news fragment to finish my PR.

@Abdullium
Copy link
Author

Abdullium commented Aug 8, 2022

This approach requires manual labor to document the variables if they are removed or added. Please see my branch here: https://github.com/pypa/pipenv/tree/document-environment-variables

You can steal this code, and add the news fragment to finish my PR.

I've cleared the issue
can you merge the request now?

I have written the command that lists all the system variables of pipenv
@oz123
Copy link
Contributor

oz123 commented Aug 8, 2022

Not yet. You still need to change environments.py and create a news entry.

@Abdullium
Copy link
Author

Not yet. You still need to change environments.py and create a news entry.

See what I suggest is that
You can merge the request now

And I will later raise the issue for any descrepancies

@oz123
Copy link
Contributor

oz123 commented Aug 8, 2022

@Abdullium thank you for your contribution, I created a PR which fixes the issue #5235 .

@oz123 oz123 closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants